Android-ConvenientBanner
Android-ConvenientBanner copied to clipboard
Clean up the `HISTIGNORE` Bash variable
The following passage from the Bash Reference Manual provides justification for the proposed changes:
HISTIGNORE
subsumes the function ofHISTCONTROL
. A pattern of ‘&
’ is identical toignoredups
, and a pattern of ‘[ ]*
’ is identical toignorespace
. Combining these two patterns, separating them with a colon, provides the functionality ofignoreboth
.
The relevant section as it stands: https://github.com/paulirish/dotfiles/blob/89368927c21c6af97d0d604a5433479ec82bda80/.bash_profile#L57-L63
Specifically, this PR is aimed at ironing out these kinks:
- Having both
&
inHISTIGNORE
andignoredups
inHISTCONTROL
is redundant. - Assuming the intention was to preserve commands with a leading space (as indicated by the comment in Line 57), the inclusion of
[ ]*
inHISTIGNORE
would be self-defeating.