PySixel icon indicating copy to clipboard operation
PySixel copied to clipboard

Update for python 3.8

Open rolveb opened this issue 4 years ago • 4 comments

Fixed compilation errros by renaming tp_print to tp_vectorcall_offset and added prefix to tstate -> type, value and traceback tstate->curexc_type = type; tstate->curexc_value = value; tstate->curexc_traceback = tb;

rolveb avatar Mar 09 '21 19:03 rolveb

Woohoo! This version works! ♥

Thank you for going through the code, so I don't have to!

jaysonlarose avatar Apr 29 '21 02:04 jaysonlarose

Could this please be merged? Master is broken. Otherwise we should declare @rolveb as the new allmighty maintainer. The guy who did something. His fork should be cherished. For now.

For people who want to get things done and move on:

pip install git+https://github.com/rolveb/PySixel.git

decryptozoo avatar Jul 01 '21 19:07 decryptozoo

I kind of want to depend on this for something I have. @rolveb, are you interested in uploading your version to pypi or taking the namespace on pypi from the current project?

Davidy22 avatar Aug 17 '21 10:08 Davidy22

Not sure why you did these changes manually, you can just call cython to regenerate:

cython sixel/converter.py -o sixel/sixel_cimpl.c

As seen in the Makefile.

You can install my fork via:

pip install git+https://github.com/lubosz/PySixel.git

Works with Python 3.11 and for all eternity without having to update the C code every Cython update

lubosz avatar Oct 16 '23 09:10 lubosz