discord-js-bot icon indicating copy to clipboard operation
discord-js-bot copied to clipboard

music wrapper changed and add lavalink v4 support

Open aikoonee opened this issue 1 year ago • 4 comments

• Changed music wrapper lavaclient to lavalink-client • Added lavalink v4 support • Added custom player events • Added autoplay feature.

aikoonee avatar Oct 07 '24 11:10 aikoonee

Why music is true in config.js?

hwangsihu avatar Oct 08 '24 08:10 hwangsihu

Why music is true in config.js?

Because I was testing the music command and forgot to set ENABLED: false in the config 😅

ghost avatar Oct 08 '24 08:10 ghost

ROFL Every time I see something like this, I think it would be better to change it to config.js.example like in my PR.

hwangsihu avatar Oct 08 '24 08:10 hwangsihu

Oh, and I think the default volume should be around 60 or 70. Anything above that is a bit noisy when doing other tasks.

hwangsihu avatar Oct 08 '24 12:10 hwangsihu

npx eslint src (node:18752) ExperimentalWarning: CommonJS module C:\Program Files\nodejs\node_modules\npm\node_modules\debug\src\node.js is loading ES Module C:\Program Files\nodejs\node_modules\npm\node_modules\supports-color\index.js using require(). Support for loading ES Module in require() is an experimental feature and might change at any time (Use node --trace-warnings ... to show where the warning was created)

C:\discord-js-bot\src\commands\music\play.js 84:9 error Unexpected lexical declaration in case block no-case-declarations

✖ 1 problem (1 error, 0 warnings)

hwangsihu avatar Oct 30 '24 08:10 hwangsihu

Please fix this issue and commit after formatting using npm run format command.

hwangsihu avatar Oct 30 '24 08:10 hwangsihu

Oh and updated lavalink-client to 2.4.1 please update this

hwangsihu avatar Oct 30 '24 08:10 hwangsihu

[2024-10-30 09:10:46] ERROR: Failed to load C:\discord-js-bot\src\commands\music\leave.js Reason: Alias disconnect already registered

hwangsihu avatar Oct 30 '24 09:10 hwangsihu

Okay Fixed My Commit

apply this commit

hwangsihu avatar Oct 30 '24 09:10 hwangsihu

Oh and updated lavalink-client to 2.4.1 please update this

2.4.1 is not stable version

ghost avatar Nov 18 '24 17:11 ghost

Okay Fixed My Commit

apply this commit

Command name is already "leave", and now the alias is also lol

ghost avatar Nov 18 '24 17:11 ghost

Good

hwangsihu avatar Nov 19 '24 15:11 hwangsihu