tmux-translator icon indicating copy to clipboard operation
tmux-translator copied to clipboard

Published 20 hours ago • verified publisher icon sainnhe

Fix auto closing popup window

Open awerebea opened this issue 3 years ago • 4 comments

Fix popup disappearing on tmux 3.3-rc.

awerebea avatar Nov 04 '21 18:11 awerebea

Thanks!

Looks like you can't close popup via Enter anymore, so the only way to close it is using Ctrl-C?

sainnhe avatar Nov 05 '21 01:11 sainnhe

Looks like you can't close popup via Enter anymore, so the only way to close it is using Ctrl-C?

Hello! No, I had another problem. The popup disappears immediately after it appears. With these changes, I can close the popup manually using Esc and Ctrl-C (but not with Enter).

awerebea avatar Nov 05 '21 06:11 awerebea

I can't reproduce this bug on tmux 3.2a stable release, the original code works fine. And with your code, I can't close popup via Esc.

I'm going to test it on development version later.

sainnhe avatar Nov 05 '21 07:11 sainnhe

I tried it on version 3.2a of tmux and I have the same behavior, so I believe it is not a version related issue. Also I tried to disable all other tmux plugins but with no success. After that, I thought it might somehow conflict with my zsh plugins, and tried it in bash, but everything remained the same. It is very strange that you cannot close popup with Esc. If so, you can reject this PR and I will continue to use this plugin from my fork, no problem. Thanks for your attention anyway!

awerebea avatar Nov 05 '21 08:11 awerebea