The frame of the git commit message editor box disappears when putting a cursor in it

[singularitti]

• Operating system/version: macOS 10.15.6 (19G73)
• VSCode version: Version: 1.47.3 Commit: 91899dcef7b8110878ea59626991a18c8a6a1b3e Date: 2020-07-23T13:08:29.692Z Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Darwin x64 19.6.0

Settings

I have tried without some extensions installed, the bug still appears.

Steps to reproduce this bug

Put a cursor into the "source control message editor".

Actual behaviour

Without cursor, it looks good:

With a cursor inside, the frame of the box disappeared:

Expected behaviour

With a cursor inside, the frame of the box still shows.

[3olkin]

Hello, thanks for your attention.

I checked fast some workbench settings for input control but this it didn't help. So I need some extra time to fix this issue. sorry for the inconvenience.

[3olkin]

Accidentally I found a solution. It look like it was an expected behavior, so without @sainnhe I won't fix it.

But here is a recipe for you, @singularitti :

1. Open your settings.json file
2. add this code:

  "workbench.colorCustomizations": {
    "[Gruvbox Material Dark]": {
      "focusBorder": color
    }
  },

3. Change color depending on your palette:

• #3d3835 for hard
• #45403d for medium
• #504945 for soft

[singularitti]

Thank you for your reply, this workaround works for me. However, I still hope this could officially be fixed. For example, the extension input box is still good even if there is a cursor in it, the only thing that is not working is the git commit message box:

[3olkin]

Personally, I'm with you, but the source code which setup this border is focusBorder: `${palette.bg5}00`, 00 means that it should be totally transparent. You can check src/workbench/ if you want

[sainnhe]

Oh, this is not expected behavior, it's a mistake when I'm designing "borderless" workbench style.

[3olkin]

@sainnhe this change will trigger some borders for windows like live share, debugger

[sainnhe]

You are going to make the decision. I can't use my PC now, and I don't use vscode very much, I use neovim for daily development. If you think the design can be accepted by most of the vscode users, then go ahead and change it.

[3olkin]

I find useless borders more annoying, so I think that "sacrifice" this border is acceptable.

But I' ll try to find a way to fix it. Probably is there anyone who have some experience in overriding vscode default behavior?

[sainnhe]

Or maybe open an issue in the vscode repository. I found another annoying bug recently: in the extension sidebar, the extension name and description can be designed to be grey, but the extension publisher is always white.

I found that the foreground color of the extension publisher is controlled by the foreground key, which means if we set it to grey, then the foreground color of every element will be grey.

I personally think that both of these 2 problem should be fixed in vscode level instead of in a color scheme.

[rdhar]

Only tangentially related to border; is there any potential to include support for the sash hover border color introduced in v1.52?

I think it'll go well as an added accent colour customization, similar to the "gruvboxMaterial.darkCursor": "green" options.

Thank you.

[sainnhe]

@rdhar Done via https://github.com/sainnhe/gruvbox-material-vscode/commit/975407e08499357c33a8bbb020810632b8f8d8c7

I'll create a new release later.

[rdhar]

Wow, that's great to hear, @sainnhe!

I'd thought you moved on away from VS Code to Neovim so this is a very welcome surprise!

Thanks for your time and effort for continuing to support the best interpretation of the Gruvbox theme that I've come across.

[sainnhe]

@rdhar

I'd thought you moved on away from VS Code to Neovim

To be honest, I'm a neovim user from the very beginning, I don't use vscode very much.

I created this theme simply because sometimes I need vscode on windows, and some of my friends need this theme.

So I'll continue to maintain this project. Btw, @Z4RX is also a maintainer of this project, he did a fantastic job, he and me will response when we have time.

This project will be actively maintained for a long time, so don't worry :)