Simon Conseil

Results 367 comments of Simon Conseil

I found by reading the code that there is an undocumented "section" feature (#61) which is almost that. Instead of adding "subsection" fragments it works with sub-directories, but this achieves...

Nice work @barentsen, it seems already in good shape. Just a note that it may take me a bit of time to review in detail due to some other activities...

> +7,675 −5,825 :scream: Yeah black uses a lot of vertical space, which is its main drawback but also has the advantage of minimizing the conflicts between PRs etc.

> This looks good though I wonder a little about the approach: in principle, the generous on input and strict on output idea would suggest that one could fall back...

> But the above does suggest that one thing that really needs to be done is to add something to the fits docs -- I started there and it has...

@mhvk - What should we do with this one ?

Moving the milestone to 5.2 so we can take more time to think at a better solution.

Moving the milestone to 5.2 since the PR doesn't seems ready.

@bwinkel - Is it OK to use the files you added in #7810 to check that the bug is fixed ? Did you generate those files, or if they come...

> I have rebased on main because of conflicts and added a test about TDIM: is '(1,1)' the expected result? Thanks! TDIM is set to `(1, 1)` in the header,...