patchmanager icon indicating copy to clipboard operation
patchmanager copied to clipboard

[Bug] in functions install and remove the patch success prevent to make the patch backup

Open robang74 opened this issue 2 years ago • 4 comments

SailFish OS version: 4.5.0.9 Patchmanger Version: 3.2.9 Hardware: Xperia 10 II

BUG DESCRIPTION

In these two functions remove_text_patch() and install_text_patch() the exit 0 in success() prevents that the backup of the installed/removed patch can be managed correctly.

STEPS TO REPRODUCE

It is in the code - it is about the flow logic.

ADDITIONAL INFORMATION

Please check this commit:

  • https://github.com/robang74/patchmanager/commit/932fee1a0bfce35f06ccb4e48ed6faa079badeda

The code is different because it refers the unified version of pm_apply and pm_unapply but it is the logic that matters.

robang74 avatar Jul 02 '23 10:07 robang74

Please take care to fix the code issues reported by this person, but create your own changes. no commits authored by this person are allowed to be merged in this repo.

CODeRUS avatar Jul 21 '23 21:07 CODeRUS

@nephros @nephros @Olf0 fyi

CODeRUS avatar Jul 21 '23 21:07 CODeRUS

@b100dian was missed.

Olf0 avatar Jul 22 '23 21:07 Olf0

Please let us carry out this meta-discussion at the oldest bug report filed by robang74: #444

Every thing discussed there an the meta-level is sure applicable to the filed issues #445 and #446, too (plus any future ones by robang74).

Olf0 avatar Jul 22 '23 21:07 Olf0