saikou icon indicating copy to clipboard operation
saikou copied to clipboard

feat: subtitle/player settings in exoplayer

Open Adolar0042 opened this issue 3 years ago • 5 comments

No idea if the settings being changed works, as Zoro seems to be broken

https://user-images.githubusercontent.com/39769465/191079344-4d1a4a7a-8553-4663-8844-fed66bf290d4.mp4

Adolar0042 avatar Sep 19 '22 17:09 Adolar0042

You were using streamsb sometimes they don’t embed subs into the video (rapid cloud = soft sub, streamsb/streamtape = hard sub)

Bilnaa avatar Sep 20 '22 20:09 Bilnaa

The rapid cloud fix came out after I made the pr, will test everything tomorrow

Adolar0042 avatar Sep 20 '22 20:09 Adolar0042

Works now!

Adolar0042 avatar Sep 21 '22 12:09 Adolar0042

I think instead of making the user reload the player, just init the exoplayer again, with same episode also please use BottomSheetDialog, instead of AlertDialog

brahmkshatriya avatar Sep 21 '22 15:09 brahmkshatriya

I've never used a BottomSheetDialog before, but I'll try.

Adolar0042 avatar Sep 21 '22 15:09 Adolar0042

(Finally) figured out how to display it without anything going wrong. I think I'll be done with this in the next 2-3 days.

image

Adolar0042 avatar Sep 23 '22 15:09 Adolar0042

Just realized that I need to update the player settings bottomsheetdialog with the new expandable categories

Adolar0042 avatar Sep 23 '22 16:09 Adolar0042

Imma do exo init tomorrow

Adolar0042 avatar Sep 23 '22 17:09 Adolar0042

Now freshly inits the exoplayer with new settings but eems to break Kamyroll, Upsidedown6Anime Backup and AniMixPlay, if anyone wants to investigate, feel free otherwise I would just hide the button when one of them is the source (Logs for investigating (from Kamyroll breaking))

Adolar0042 avatar Sep 23 '22 21:09 Adolar0042