Please run Babel or similar for dist

[hmedney]

First, thanks for this useful library 😃. Minor suggestion - please consider running the source through Babel or similar before publishing such that the distributable code is all ES5. This will eliminate js compatibility issues when bundling and minifying this package (ran into an issue recently with backticks in this package). Thanks!

[rob-mcgrail]

Yeah those backticks wasted a couple of hours of my life.

edit - this library also probably saved me a bunch of time too, so it's a wash. Thanks for your contributions.

[saikojosh]

OK I'll setup Babel when I get time. I didn't anticipate people would want to use this on frontend, my bad!

[mattotodd]

I just spent an hour of my life trying to track down an IE11 error: SCRIPT1014: Invalid character

Was related to the backticks in this library

[PabloDiablo]

Yep just hit this issue myself when running production code through Uglify: Unexpected character '`'

[gReis89]

@saikojosh any update on this? I saw a PR opened on July, can we have it merged and released?

[saikojosh]

I've converted the module to single quotes now so should work fine. When I have more time I will look at the Babel PR.

[thelastfantasy]

Same problem, my project created with create-react-app got err, any idea to solve this problem?

[saikojosh]

Which version of this module are you using? I removed backticks from the latest version.

Regards, -Josh Cole. Sent from my iPhone.

On 14 Apr 2018, at 16:55, thelastfantasy [email protected] wrote:

Same problem, my project created with create-react-app got err, any idea to solve this problem?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[thelastfantasy]

0.4.0, I downloaded it with npm. I ran babel CLI to output an es5 version and it's ok now.

[shockey]

Chiming in here - integrating object-assign-deep broke our module (swagger-client) for Node 4 users due to use of const in the published module: https://github.com/swagger-api/swagger-js/issues/1315. It breaks in IE11 too, but our Babel sidestepped that problem.

Please consider transpiling 😄

[saikojosh]

@shockey Node 4 went end-of-life a month ago. I plan to merge in one of the PRs but I don't have time to do a full review right now. It's not a priority seeing as Node 4 is no longer supported.

[mkanako]

my project is webpack4+vue create by vue-cli 3.0 I know this package have es6 syntax and babel igonre all files inside node_modules by default so need to add transpileDependencies: ['object-assign-deep'] to vue.config.js but error also happens unfortunately Cannot assign to read only property 'exports' of object '#<Object>'

I have no way😭

[shockey]

@mkanako my fork may solve your issue, it’s the same aside from the fact that it ships already transpiled through Babel: https://www.npmjs.com/package/@kyleshockey/object-assign-deep

[mkanako]

@shockey thank you very much!! you solved my problem immediately!!