fuwari icon indicating copy to clipboard operation
fuwari copied to clipboard

feat: add post pinning functionality

Open VrianCao opened this issue 8 months ago • 5 comments

  • Add pinned field to post schema and frontmatter
  • Implement sorting logic to prioritize pinned posts
  • Display pin icon for pinned posts in main blog and archive views
  • Update documentation in README files with pinned feature details

VrianCao avatar May 01 '25 14:05 VrianCao

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuwari-yags ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2025 2:59pm

vercel[bot] avatar May 01 '25 14:05 vercel[bot]

@JoeyC-Dev Have a check on new code XD

VrianCao avatar May 01 '25 14:05 VrianCao

Adding PR history: https://github.com/saicaca/fuwari/pull/422 CC @L4Ph

As in https://github.com/saicaca/fuwari/discussions/356, currently new feature will not be merged. So pending on repo owner when repo owner is back.

@L4Ph It is quite long time, may you consider creating another repo for merging these new features to see the outcome when they are being implemented?

JoeyC-Dev avatar May 01 '25 15:05 JoeyC-Dev

As in #356, currently new feature will not be merged. So pending on repo owner when repo owner is back.

I see, it's not a big problem, it's just a small feature improvement, we can take it slow.

@L4Ph It is quite long time, may you consider creating another repo for merging these new features to see the outcome when they are being implemented?

I think this would be a good suggestion. Time waits for no one, once it's delayed too long, there will be more PRs, and merging the code will become almost impossible.
Maybe we can create a new repo or branch to merge these PRs first.

VrianCao avatar May 01 '25 17:05 VrianCao

Let's say you merge that "new feature" into another repository.

  • Who will maintain the differences with saicaca/main?
  • When should you issue a pull request from that repository to saicaca/main?
  • Who should be credited with a pull request for a similar feature?

There are many things to consider. I don't have the time or confidence to maintain two repositories that are similar but have different implementations.

I don't think there's much to be gained from discussing this further here, so let's move on to the discussion below...

#434

L4Ph avatar May 01 '25 21:05 L4Ph