libsmb2 icon indicating copy to clipboard operation
libsmb2 copied to clipboard

CMakeLists.txt statement "if(NOT PICO_BOARD OR NOT ESP_PLATFORM)"

Open marnikvd opened this issue 1 year ago • 2 comments

Hello, This issue brought me here. I'm not able to compile the esp-idf-smb-client in VSCODE. My ESP-IDF version is 5.2.1 To narrow down the problem I would like to understand why the CMakeLists.txt file in libsmb2 has the following statements https://github.com/sahlberg/libsmb2/blob/69bc169d8d029b2d523d6522ee6799f99d481575/CMakeLists.txt#L47 and https://github.com/sahlberg/libsmb2/blob/69bc169d8d029b2d523d6522ee6799f99d481575/CMakeLists.txt#L71 This means that the if block is ALWAYS executed EXCEPT when you compile for raspberry pi pico AND esp32 at the same time. Can someone confirm that this is correct? As a consequence I get this error :

  CMake Error at
  C:/Users/marnik/esp/mijnProjecten/esp-idf-smb-client/components/libsmb2/CMakeLists.txt:72
  (include):

    include could not find requested file:



      cmake/ConfigureChecks.cmake

marnikvd avatar Oct 08 '24 22:10 marnikvd

I don't have any of these platformsand don't really use cmake myself, so any patches or fixes in this are depends on controbutions.

sahlberg avatar Dec 14 '24 23:12 sahlberg

Hello, This issue brought me here. I'm not able to compile the esp-idf-smb-client in VSCODE. My ESP-IDF version is 5.2.1 To narrow down the problem I would like to understand why the CMakeLists.txt file in libsmb2 has the following statements

https://github.com/sahlberg/libsmb2/blob/69bc169d8d029b2d523d6522ee6799f99d481575/CMakeLists.txt#L47

and https://github.com/sahlberg/libsmb2/blob/69bc169d8d029b2d523d6522ee6799f99d481575/CMakeLists.txt#L71

This means that the if block is ALWAYS executed EXCEPT when you compile for raspberry pi pico AND esp32 at the same time. Can someone confirm that this is correct? As a consequence I get this error :

  CMake Error at
  C:/Users/marnik/esp/mijnProjecten/esp-idf-smb-client/components/libsmb2/CMakeLists.txt:72
  (include):

    include could not find requested file:



      cmake/ConfigureChecks.cmake

I will see this today when i will fix some builds which they are falling.

Wolf3s avatar Dec 15 '24 12:12 Wolf3s