libnfs icon indicating copy to clipboard operation
libnfs copied to clipboard

Is there a plan to support v4.1

Open amandeepgautam opened this issue 5 years ago • 21 comments

Hi, Is there a plan to support v4.1? If no, how much work would be needed if one plans to do it? What parts of the lib needs to change.

amandeepgautam avatar Apr 29 '20 19:04 amandeepgautam

Not really. The reason is mostly that the main big feature of v4.1 is pNFS and I doubt it would be meaningful to implement it in libnfs.

Otherwise, excluding pNFS it would not be that hard to add 4.1 support. Just updating the .x file with the new additions, regenerate the corresponding .h/.c files and then start calling/using the new features from the main library. But I don't think there would be much value in doing it.

sahlberg avatar Apr 30 '20 02:04 sahlberg

Adding I am not against adding v4.1 support but lacking pNFS support (which I don't think libnfs will have) I personally see little reason to add it.

If you have a compelling reason why 4.1 support would be useful I can reconsider.

sahlberg avatar May 06 '20 10:05 sahlberg

Having the support for sessions in NFSv4.1 is a big plus. People are no longer switching to v4 but are switching to v4.1 which require support for sessions. pNFS support is optional.

amandeepgautam avatar May 12 '20 10:05 amandeepgautam

Ok, that is a valid point. Do you have wireshark captures I can look at for 4.1 multisession? Are you willing to test if I add session support?

I can't promise anything, but if there is genuine need and use for these features I can make an attempt.

sahlberg avatar May 12 '20 11:05 sahlberg

Thanks. Yes, I can help with the testing. I have attached the traces for mount using v4.1. Let me know if these are sufficient. Also, when you think this can be done not as a promise but just to get an idea?

mount_tcp_mount_nfs4.pcap.zip

amandeepgautam avatar May 13 '20 01:05 amandeepgautam

@sahlberg Any luck on this?

amandeepgautam avatar Jun 03 '20 04:06 amandeepgautam

@sahlberg Just checking if there is any update on this.

amandeepgautam avatar Jul 07 '20 08:07 amandeepgautam

I have added the low level opcodes that are new in 4.1 but not yet added any code to actually use them.

In a few weeks I may have time to start to add the plumbing to the v4 layer to actually use these new commands.

On Tue, Jul 7, 2020 at 6:10 PM Aman Deep Gautam [email protected] wrote:

@sahlberg https://github.com/sahlberg Just checking if there is any update on this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sahlberg/libnfs/issues/314#issuecomment-654677114, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADY3EEQHL7LMJPQQIVCCGTR2LJ7TANCNFSM4MUAKWZQ .

sahlberg avatar Jul 11 '20 07:07 sahlberg

@sahlberg awesome, thanks!

amandeepgautam avatar Jul 12 '20 02:07 amandeepgautam

Hi @sahlberg! Any progress on this since the last time we chat? I may need this soon and can help with testing and bugfixes. But it would be great if the framework code is checked in as I would not need much familiarity with the library internals in that case.

amandeepgautam avatar Aug 21 '20 20:08 amandeepgautam

@sahlberg gentle ping.

amandeepgautam avatar Sep 23 '20 18:09 amandeepgautam

@sahlberg just wondering if there is any progress on this. Apologies for asking again.

amandeepgautam avatar Oct 26 '20 21:10 amandeepgautam

No progress yet. I hope to find time to do this over the holidays.

On Tue, Oct 27, 2020 at 7:04 AM Aman Deep Gautam [email protected] wrote:

@sahlberg https://github.com/sahlberg just wondering if there is any progress on this. Apologies for asking again.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sahlberg/libnfs/issues/314#issuecomment-716822564, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADY3EFUQB3XINU2UQEWHVLSMXP6DANCNFSM4MUAKWZQ .

sahlberg avatar Oct 27 '20 07:10 sahlberg

@sahlberg thanks! Will be excited to use the feature. I use libsmb2 as well and it's awesome that I would be able to use almost the same code for libnfs. Very elegant.

amandeepgautam avatar Oct 27 '20 08:10 amandeepgautam

@sahlberg Sorry to bug you again, but I realized that we are in different countries. Just curious to know when are the holidays?

amandeepgautam avatar Oct 29 '20 03:10 amandeepgautam

On Thu, Oct 29, 2020 at 1:58 PM Aman Deep Gautam [email protected] wrote:

@sahlberg https://github.com/sahlberg Sorry to bug you again, but I realized that we are in different countries. Just curious to know when are the holidays?

End of december. Yule/Christmas and NewYear

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sahlberg/libnfs/issues/314#issuecomment-718344036, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADY3EEAZXJ3Q4ET6BXNIZTSNDR45ANCNFSM4MUAKWZQ .

sahlberg avatar Oct 29 '20 04:10 sahlberg

Unfortunately I won't be able to implement this support this holidays as it may be a lot bigger than I originally thought.

Maybe later during 2021.

On Thu, Oct 29, 2020 at 2:54 PM ronnie sahlberg [email protected] wrote:

On Thu, Oct 29, 2020 at 1:58 PM Aman Deep Gautam [email protected] wrote:

@sahlberg https://github.com/sahlberg Sorry to bug you again, but I realized that we are in different countries. Just curious to know when are the holidays?

End of december. Yule/Christmas and NewYear

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sahlberg/libnfs/issues/314#issuecomment-718344036, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADY3EEAZXJ3Q4ET6BXNIZTSNDR45ANCNFSM4MUAKWZQ .

sahlberg avatar Dec 14 '20 20:12 sahlberg

@sahlberg Perhaps partial support in a separate branch and I can pick it up the remaining work. later those can be merged in the mainline once completed.

amandeepgautam avatar Dec 14 '20 20:12 amandeepgautam

@sahlberg do we have a plan to put the support sometime in future?

amandeepgautam avatar Apr 22 '21 20:04 amandeepgautam

Hi @sahlberg! I am also looking for an NFSv4.1 client library. Is there any plan to support v4.1 in libnfs yet.

varunbharill avatar Apr 26 '22 13:04 varunbharill

I have no plans for 4.1 because I do not personally need that functionality. It would not be very hard to add, just a lot of timeconsuming implementation and testing which I do not have cycles for. I am happy to advice if someone wants to add this support.

It is a somewhat large amount of work. I am open to work under sponsorship.

sahlberg avatar May 01 '22 09:05 sahlberg