mobileplayer-ios icon indicating copy to clipboard operation
mobileplayer-ios copied to clipboard

status bar isHidden not right in viewWillAppear

Open sandyway opened this issue 8 years ago • 1 comments

test on iOS 10.2


This change is Reviewable

sandyway avatar Jan 23 '17 09:01 sandyway

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


MobilePlayer/MobilePlayerViewController.swift, line 159 at r1 (raw file):

            NotificationCenter.default.post(name: NSNotification.Name(rawValue: MobilePlayerDidEncounterErrorNotification), object: self, userInfo: [MobilePlayerErrorUserInfoKey: error])
        }
        if let postrollVC = slf.postrollViewController, !slf.isBeingDismissed {

Could you separate this line change to a different branch and send another pull request?


MobilePlayer/MobilePlayerViewController.swift, line 232 at r1 (raw file):

    
    // Force hide status bar.
    previousStatusBarHiddenValue = UIApplication.shared.isStatusBarHidden

Hiding the status bar in viewDidLoad while its state is being restored when the view disappears will cause issues in certain use cases.

Could you check the latest master and let me know if you still have problems with the status bar?


MobilePlayer/Views/Slider.swift, line 18 at r1 (raw file):

}

class LargeTouchAreaUIView: UIView {

Could you separate the changes related to the slider to a different branch and send another pull request? Also, it'd be great if you could put the definition of LargeTouchAreaUIView in a new file.


Comments from Reviewable

isair avatar May 09 '17 13:05 isair