Sahil Phule

Results 28 comments of Sahil Phule

Also, I have replied to the comments.

@acasajus Thanks for the feedback. Yes, I understand that there are no tests, and I can certainly write some if needed, but I believe, ideally, tests should be written by...

@empeje Oh. This one wasn't merged yet :sweat_smile: ? I'll fix the conflicts and then you can merge it

@empeje I have fix the conflicts and also removed the versions which can't be compiled. Since the version is updated to 2.1.2 and 1.7.2 we should first test them on...

@proudparrot2: > I'm running Umbrel on my home network, and I want to put it behind a Caddy reverse proxy to get https support and to put it on my...

> What if we already have a domain; do you have plans for e.g. LetsEncrypt certificates/CA-signed certs? Still thinking LAN use only. Adding LetsEncrypt support and also adhering to Umbrel's...

@nmfretz I have made the requested changes. Please check.

> Forward Hostname / IP = `umbrel.local` | port = `8096` --> I am hit with a 502 bad gateway Ahh, this is interesting. I get the same 502 bad...

> For any apps that sit behind the app_proxy with authentication enabled (by default), they would need to proxy using case 4 above, where they bypass the the app_proxy and...