yamldiff icon indicating copy to clipboard operation
yamldiff copied to clipboard

Change diffing, adds Path printing

Open tyler-boyd opened this issue 3 years ago • 3 comments

Fixes https://github.com/sahilm/yamldiff/issues/7 by pulling out kylelemons/godebug/pretty and using r3labs/diff to generate the diff instead.

This enables printing a path before the diff.

Example output: image

I hope this is valuable to others, but at the very least I will be using this so it won't go to waste regardless 🙂

Also: I use a much newer version of Go than you, I think. The Gopkg.lock diff is pretty big because of that.

Perhaps it would make more sense to add this behind a flag (eg. --show-paths) to maintain backwards-compatibility; I can implement that if you'd like.

tyler-boyd avatar Jul 20 '20 20:07 tyler-boyd

cc/ @sahilm , not sure if you would get a notification from me opening this PR.

tyler-boyd avatar Jul 20 '20 20:07 tyler-boyd

@sahilm , please consider this pull pull-request from @tyler-boyd . I love yamldiff, it has such great potential, but without having the context of the change, it is not very useful.

per-bohlin avatar Jan 13 '21 08:01 per-bohlin

@sahilm this would be a very useful thing. Are you still actively maintaining this tool?

scarby avatar May 19 '21 21:05 scarby

I know this is super late but I just incorporated this change in https://github.com/sahilm/yamldiff/pull/19. Sorry 😐.

cc: @tyler-boyd @per-bohlin @scarby @hermanbanken

sahilm avatar Oct 02 '23 11:10 sahilm

No worries, thank you!

tyler-boyd avatar Oct 02 '23 15:10 tyler-boyd