tinygo-keyboard icon indicating copy to clipboard operation
tinygo-keyboard copied to clipboard

Implementation of vialrgb

Open PercyJW-2 opened this issue 1 year ago • 8 comments

I have implemented hid communication needed to control rgb via vial. I don't know if this is clean enough to merge, but I have a working keyboard implementation at this repository. Moreover, I maybe don't have enough time to bring the implementation up to a mergable standard but still want to provide at least inspiration for a proper implementation

PercyJW-2 avatar Aug 15 '24 15:08 PercyJW-2

Also, there is a problem with the usage of the machine package, and don´t quite know how to fix this

PercyJW-2 avatar Aug 15 '24 15:08 PercyJW-2

@PercyJW-2 I'm very grateful for the work on VialRGB support. I'm looking forward to it. Please clean up the Git history and remove any unnecessary changes. Typically, you can do this by performing a rebase once and then removing unnecessary changes like those in .gitignore.

$ git checkout main
$ git checkout -b vialrgb-work
$ git reset --soft sago35/main
$ git commit

image

sago35 avatar Aug 17 '24 09:08 sago35

Additionally, there is no need to modify go.mod for this PR. Please revert any changes made to it. If not modifying it results in any errors, please let me know. We can work together to find a solution.

sago35 avatar Aug 17 '24 09:08 sago35

I only modified the go.mod to be able to use on my own project. For this draft I just wanted to show what I have done. To be able to merge this implementation I am fully aware that there are some cleanups necessary. I will continue to improve this implementation and then do the cleanup and open a new pull request with a cleaned up branch

-------- Original Message -------- On 8/17/24 11:33, sago35 wrote:

Additionally, there is no need to modify go.mod for this PR. Please revert any changes made to it. If not modifying it results in any errors, please let me know. We can work together to find a solution.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

PercyJW-2 avatar Aug 17 '24 10:08 PercyJW-2

Nice, it seems like, that that did the job

PercyJW-2 avatar Aug 18 '24 00:08 PercyJW-2

Is there anything I can do to help move this PR forward? @PercyJW-2

sago35 avatar Feb 14 '25 22:02 sago35

I haven't looked at this for some time, but my last problem was, that the firmware hangs when running any kind of RGB animation and I could not debug why that is the case. If you want, you could look into it.

-------- Original Message -------- On 2/14/25 23:31, sago35 wrote:

Is there anything I can do to help move this PR forward? @.***(https://github.com/PercyJW-2)

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

[sago35]sago35 left a comment (sago35/tinygo-keyboard#47)

Is there anything I can do to help move this PR forward? @.***(https://github.com/PercyJW-2)

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

PercyJW-2 avatar Feb 15 '25 08:02 PercyJW-2

At this point, --stack-size 8kb is required during the build. From my tests on rp2040-zero, everything except RGB seems to be working fine.

@PercyJW-2

sago35 avatar Feb 16 '25 10:02 sago35