Saúl Ibarra Corretgé
Saúl Ibarra Corretgé
> Firewire devices would end up included in the output now (as regular ip devices), and they have 8 bytes of physical address. This is how sockaddr_ll and IP_ADAPTER_ADDRESSES specify...
Gotcha, go ahead with the length :-)
My 2 cents: I'd expect people to set the desired delay when they enable the feature. It doesn't matter what value is set when disabling, so let's ignore that case...
> This code wouldn't do as described, delay is only set when enabling If 0 uses the previously stored delay, then this limitation makes things really confusing, why can't one...
I guess we could also swtich the implementation to https://docs.microsoft.com/en-us/windows/win32/winsock/sio-keepalive-vals and maybe that makes the 0 case behave correctly?
I see. If I got it correctly I think I'm +1 here then.
Random thought: maybe we could use this _ex function to add this functionality too: https://github.com/libuv/libuv/issues/2536 (in between releases, so this doesn't need to wait longer before merge)
> Is this still going to be worked on, or could it be taken to push forward by volunteers? I don't think anyone would oppose a volunteer pushing it forward.
Out of curiosity, where / how did you find this?
Heads up: this one will conflict heavily with https://github.com/libuv/libuv/pull/2504 I believe that landing https://github.com/libuv/libuv/pull/2504 first is a good idea here, since it targets our build more broadly than just making...