Saúl Ibarra Corretgé
Saúl Ibarra Corretgé
The main reason is we followed the SFrame draft (-00): https://tools.ietf.org/html/draft-omara-sframe-00 We did start with GCM and will likely return to it. SFrame is still a young document and we...
We are using GCM now.
Ugh, good point! How about we generate an uuid v4 in that case?
> I added the uuid v4 generation on JM. Add it here please, so the applications don't need to worry about that and can assume it's there.
Code looks good but you need to fix the import order. Run "npm run lint" to see exactly what's wrong, or check the CI step output.
Looks like there are some typing errors you need to tackle in the JM PR: ~~~ + cd jitsi-meet + PID_MAKE=585237 + wait 585237 + make NODE_OPTIONS=--max-old-space-size=8192 \ ./node_modules/.bin/webpack [BABEL]...
> For the parameters, lint says to put them in ascending order. Should I do that or did we want to keep the custom order? And if so do I...
Jenkins please test this please.
Unrelated test failure, landing.
Great work @he-patrick ! 🚀