Saúl Ibarra Corretgé

Results 3597 comments of Saúl Ibarra Corretgé

What exactly are you trying to do? The native API is not stable or safe to consume directly.

Are you able to reproduce this on meet.jit.si? Can you please test the latest 10.2 SDK?

No objections from me, but I would handle that in a separate PR.

Not a fan of using regexes for this. @aaronkvanmeerten WDYT? Sprout (which we use in the tempalting engine) supports parsing an IP address, but it doesn't seem to support splitting...

Honestly at that point I'd rather do the `IP#port` syntax since it's unambiguous.

@aaronkvanmeerten are you still ok to land this?

This is not something we can solve due to the nested frames limitations.

For strings we have an api that copies data and one that doesn't. Should we have the same here? /cc @chqrlie

Sorry I think I was thing about arraybuffer. In txiki.js I have both use cases, but the one I use the most is the one that doesn't copy. This is...

This is the little wrapper I use: https://github.com/saghul/txiki.js/blob/4896636f13dd298468c9f6b3d46cbc0dcbab12b3/src/utils.c#L262 since `JS_NewUint8Array` does not copy the data but needs a freeing function. When reading data from a socket with libuv I allocate...