sage icon indicating copy to clipboard operation
sage copied to clipboard

Fix vector and matrix division for cartesian product ring

Open whoami730 opened this issue 4 months ago • 6 comments

Fixes #40626.

  • Enables vector division by scalar, vector and matrix
  • Enables matrix division by scalar and matrix

:memo: Checklist

  • [x] The title is concise and informative.
  • [x] The description explains in detail what this PR is about.
  • [x] I have linked a relevant issue or discussion.
  • [x] I have created tests covering the changes.
  • [x] I have updated the documentation and checked the documentation preview.

:hourglass: Dependencies

#40648: fixes segfaults during multiplication by inverse

whoami730 avatar Aug 21 '25 17:08 whoami730

Documentation preview for this PR (built with commit 97ba63f941f548db731efa32699b05c450ade676; changes) is ready! :tada: This preview will update shortly after each push to this PR.

github-actions[bot] avatar Aug 21 '25 20:08 github-actions[bot]

you could have instead written "TESTS:"

the logic is that a line ending by "::" must be followed by an empty line then an indented block

fchapoton avatar Aug 23 '25 06:08 fchapoton

you could have instead written "TESTS:"

the logic is that a line ending by "::" must be followed by an empty line then an indented block

Thanks, updated.

whoami730 avatar Aug 23 '25 07:08 whoami730

I'd wait for the dependency first, so far I haven't really looked into what this change does.

user202729 avatar Sep 02 '25 14:09 user202729

@user202729 Requesting a review for this PR. Thanks in advance!

whoami730 avatar Oct 26 '25 16:10 whoami730

Hello, please merge the last develop branch. @whoami730

cxzhong avatar Nov 19 '25 11:11 cxzhong