sage icon indicating copy to clipboard operation
sage copied to clipboard
verified publisher icon sagemath

Added two missing difference sets, updated URLs

Open dmgordo opened this issue 1 year ago • 5 comments

:memo: Checklist

  • [ ] The title is concise and informative.
  • [ ] The description explains in detail what this PR is about.
  • [ ] I have linked a relevant issue or discussion.
  • [ ] I have created tests covering the changes.
  • [ ] I have updated the documentation and checked the documentation preview.

:hourglass: Dependencies

dmgordo avatar Oct 02 '24 20:10 dmgordo

Documentation preview for this PR (built with commit f711216e8c951dfaf75158b685e360e1482305fa; changes) is ready! :tada: This preview will update shortly after each push to this PR.

github-actions[bot] avatar Oct 03 '24 11:10 github-actions[bot]

Nice. Can you perhaps add the info on the groups in the non-cyclic examples?

I added some information. Let me know if that's what you had in mind.

dmgordo avatar Oct 04 '24 15:10 dmgordo

looks good, let's wait for CI to finish.

dimpase avatar Oct 04 '24 15:10 dimpase

Can anyone shed light on the failed check? codecov says that line 519 isn't covered by a test, but it is, and all that changed was what the url variable was set to; I can't see how that would make the code go from passing to failing the check.

Could codecov be wrong? A similar issue came up here: https://github.com/ballerina-platform/ballerina-lang/issues/31348 .

dmgordo avatar Oct 11 '24 03:10 dmgordo

codecov is too strict. If it's an innocent place, no need to add a test.

dimpase avatar Oct 11 '24 07:10 dimpase