sage icon indicating copy to clipboard operation
sage copied to clipboard

Published 20 hours ago • verified publisher icon sagemath

Move metadata from `src/setup.cfg` to `src/pyproject.toml`

Open tobiasdiez opened this issue 1 year ago • 3 comments

Cherry-picked from https://github.com/sagemath/sage/pull/38714 for easier review.

:memo: Checklist

  • [ ] The title is concise and informative.
  • [ ] The description explains in detail what this PR is about.
  • [ ] I have linked a relevant issue or discussion.
  • [ ] I have created tests covering the changes.
  • [ ] I have updated the documentation and checked the documentation preview.

:hourglass: Dependencies

tobiasdiez avatar Sep 28 '24 03:09 tobiasdiez

Documentation preview for this PR (built with commit 84de1a59af2cc18619d495d88af155bcc9aeda26; changes) is ready! :tada: This preview will update shortly after each push to this PR.

github-actions[bot] avatar Sep 28 '24 05:09 github-actions[bot]

The changes are an unmodified subset of https://github.com/sagemath/sage/pull/38714. -> Author: @mkoeppe

Tests are passing (to the extend that they are normally passing), changes look good to me, thus setting to positive review. -> Reviewer: @tobiasdiez

tobiasdiez avatar Sep 28 '24 06:09 tobiasdiez

Matthias, this PR was meant to help you get your code in. But sadly you do not seem to be interested in any form of compromise...

Setting this to disputed. Not sure how to count votes since Matthias is both the author as well as the disputer 🤣

tobiasdiez avatar Sep 29 '24 08:09 tobiasdiez

With the meson build now in place, I don't see a point anymore in improving the setup around setuptools. If someone still feels this is worthwhile to do, feel free to reopen.

tobiasdiez avatar Oct 28 '24 14:10 tobiasdiez