cysignals icon indicating copy to clipboard operation
cysignals copied to clipboard

Install cysignals-CSI-helper as package data for better portability

Open mgorny opened this issue 1 year ago • 1 comments

Rather than installing cysignals-CSI-helper.py into a share directory and then trying to figure out the correct path to it, install it as Python package data and use the standard importlib.resources API to access it. For Python versions older than 3.9, the importlib_resources backport is used instead.

Fixes #200

mgorny avatar Jul 06 '24 11:07 mgorny

Thanks for working on this.

orlitzky avatar Jul 09 '24 17:07 orlitzky

@mkoeppe any reason not to merge this? Without it, we guess the wrong path on Gentoo.

orlitzky avatar Oct 06 '24 01:10 orlitzky

This should be updated, as we don't deal with python < 3.9 here any more. @tobiasdiez - does this fit into the meson setup?

dimpase avatar Nov 18 '24 16:11 dimpase

Yes, one can easily control where the script should be installed. https://github.com/sagemath/cysignals/blob/main/src/scripts/meson.build

tobiasdiez avatar Nov 19 '24 02:11 tobiasdiez

@mgorny - please take a look at the PR to move this forward: https://github.com/mgorny/cysignals/pull/1

dimpase avatar Nov 19 '24 05:11 dimpase

Err, that PR doesn't apply cleanly to my branch, i.e. GH doesn't let me merge it. Feel free to just overwrite my branch (it's open to maintainers) or replace the PR.

mgorny avatar Nov 19 '24 05:11 mgorny

Err, that PR doesn't apply cleanly to my branch, i.e. GH doesn't let me merge it. Feel free to just overwrite my branch (it's open to maintainers) or replace the PR.

while maintainers are too busy, and I'm not one, the quickest way forward would be just to force-push my branch into your PR.

dimpase avatar Nov 19 '24 05:11 dimpase

Err, that PR doesn't apply cleanly to my branch, i.e. GH doesn't let me merge it. Feel free to just overwrite my branch (it's open to maintainers) or replace the PR.

while maintainers are too busy, and I'm not one, the quickest way forward would be just to force-push my branch into your PR.

Done.

mgorny avatar Nov 19 '24 12:11 mgorny

@vbraun - can you promote me to maintainer here, or otherwise take care of this and other PRs waiting here?

dimpase avatar Nov 19 '24 15:11 dimpase

I haven't figured out to invoke testgdb.py from pytest. Any pointers?

dimpase avatar Nov 19 '24 15:11 dimpase

I haven't figured out to invoke testgdb.py from pytest. Any pointers?

This still uses unittest. So one needs to first migrate it to pytest, and then rename it to end on _test.py so that it gets automatically collected by pytest. I'll open an issue to track this.

tobiasdiez avatar Nov 20 '24 06:11 tobiasdiez