cysignals
cysignals copied to clipboard
Install cysignals-CSI-helper as package data for better portability
Rather than installing cysignals-CSI-helper.py into a share directory and then trying to figure out the correct path to it, install it as Python package data and use the standard importlib.resources API to access it. For Python versions older than 3.9, the importlib_resources backport is used instead.
Fixes #200
Thanks for working on this.
@mkoeppe any reason not to merge this? Without it, we guess the wrong path on Gentoo.
This should be updated, as we don't deal with python < 3.9 here any more. @tobiasdiez - does this fit into the meson setup?
Yes, one can easily control where the script should be installed. https://github.com/sagemath/cysignals/blob/main/src/scripts/meson.build
@mgorny - please take a look at the PR to move this forward: https://github.com/mgorny/cysignals/pull/1
Err, that PR doesn't apply cleanly to my branch, i.e. GH doesn't let me merge it. Feel free to just overwrite my branch (it's open to maintainers) or replace the PR.
Err, that PR doesn't apply cleanly to my branch, i.e. GH doesn't let me merge it. Feel free to just overwrite my branch (it's open to maintainers) or replace the PR.
while maintainers are too busy, and I'm not one, the quickest way forward would be just to force-push my branch into your PR.
Err, that PR doesn't apply cleanly to my branch, i.e. GH doesn't let me merge it. Feel free to just overwrite my branch (it's open to maintainers) or replace the PR.
while maintainers are too busy, and I'm not one, the quickest way forward would be just to force-push my branch into your PR.
Done.
@vbraun - can you promote me to maintainer here, or otherwise take care of this and other PRs waiting here?
I haven't figured out to invoke testgdb.py from pytest. Any pointers?
I haven't figured out to invoke
testgdb.pyfrompytest. Any pointers?
This still uses unittest. So one needs to first migrate it to pytest, and then rename it to end on _test.py so that it gets automatically collected by pytest. I'll open an issue to track this.