Safwan Rahman comments

Results 78 comments of


                                            Safwan Rahman

Example for sending notification throws error.

I think `_send_notifications` is an internal API. therefore from the user end, it should not be used.

Example for sending notification throws error.

Yap. Comment should be added what type its expecting. But it will be not a good idea to use it from outside.

Example for sending notification throws error.

> shouldn't the json.dumps(payload) be in the _send_notifications? I think it should not be there. Can you please explain why it should be there?

Example for sending notification throws error.

@jamaalscarlett Actually, according to specification, payload only allows text. we make the dictionary to json so we can send the text to browser then parse the json from the text....

Allow translations in subscribing UI

We can use `gettext`

Document.related_model has a dangerous use case

@timo-piirmann Good observation! I have never thought about it! Thanks a lot. This need to be fixed with priority

Field 'id' expected a number but got '41jl7ngByXlYCcE8rXBp' with to_queryset()

Interesting. Need to look at it. @saadmk11 Will you have some time to look?

./manage.py search_index --rebuild does not work

@pausanchezv Which Elasticsearch version?

Filter populate command

@herrnici Can you explain your usecase?

Allow custom routing and index prefixing during bulk indexing using aliases and index templates.

Thanks for the PR. Can you add some documentation for this?