vue-file-agent icon indicating copy to clipboard operation
vue-file-agent copied to clipboard

Fixes a malformedURI error

Open JoeCianflone opened this issue 3 years ago • 1 comments

My webpack CSS-loader started throwing an error today that vue-file-agent.css has a malformed URI. I tracked it down to this one line here. I don't know why this started today, I've had zero issues with this for the past several months, I can only assume that css-loader changed something today. Anyway, I tested this locally all I did was encode the svg uri and it works again.

Honestly I'm not sure if this is a me issue or not, but I figure if the encoding fixes an edge case and it still works for everyone else than it might be good to let you see it and decide if you want to pull in these changes.

Thanks for this product, it's awesome!

JoeCianflone avatar Mar 28 '21 20:03 JoeCianflone

I think it's better to encode the whole svg string in base64 altogether.

safrazik avatar Apr 29 '21 08:04 safrazik