knockout-file-bindings icon indicating copy to clipboard operation
knockout-file-bindings copied to clipboard

Fix DataURLs in polluted environments.

Open evantobin opened this issue 3 years ago • 2 comments

Iterating with in is not safe on objects that could be polluted like Array because it will pick up the polluted properties as well. This fix allows this plugin to be used within Salesforce B2B Commerce and provides no meaningful change for those not in environments where Array isn't polluted.

evantobin avatar May 27 '21 22:05 evantobin

This PR safe my day ! Thanks !!! FYI : https://stackoverflow.com/questions/500504/why-is-using-for-in-for-array-iteration-a-bad-idea

Dcosmas avatar Apr 05 '24 09:04 Dcosmas

@safrazik do you have any intention of merging this in or is this project abandoned?

evantobin avatar Apr 05 '24 12:04 evantobin