portmaster icon indicating copy to clipboard operation
portmaster copied to clipboard

Allow single character tld (for internal usage)

Open dhx opened this issue 2 years ago • 2 comments

First at all many thanks for this great useful project.

Regarding this PR please consider it only as a suggestion, I can understand that loosening the constraints on the top level domain might not be something everyone wants, so I guess it might be better to make it configurable. On the other hand the option "Block Unofficial TLDs" should limit the TLDs anyway so maybe having the regular expression too restrictive might not be too important?

For me I unfortunately had to disable this to be able to use portmaster on a not conforming internal network. So if this could land in some way I'd be happy so I don't have to use a custom build! :pray:

Best regards from Tirol!

dhx avatar Nov 09 '22 20:11 dhx

Thanks for the PR. I will look into it in the next weeks.

dhaavi avatar Nov 10 '22 16:11 dhaavi

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 15 '22 12:11 CLAassistant