Upgrade left stale launcher binary?

[Terrance]

[Pulling https://github.com/safing/portmaster/issues/1383#issuecomment-1937895628 into its own issue as this has just happened again. It was suggested last time to ask the community, which I did at the time on Discord but didn't receive any responses.]

Pre-Submit Checklist:

• Check applicable sources for existing issues:
  • Windows Known Issues
  • Linux Known Issues
  • Github Issues

What happened:

Trying to launch Portmaster's UI gives me the following unclosable error screen:

And indeed the referenced file does not exist:

$ ls -1 updates/all/ui/modules/
assets_v0-3-1.zip
assets_v0-3-1.zip.sig
portmaster_v0-8-2.zip
portmaster_v0-8-2.zip.sig
portmaster_v0-8-3.zip
portmaster_v0-8-3.zip.sig
portmaster_v0-8-6.zip
portmaster_v0-8-6.zip.sig

This looks like some components were updated, but the portmaster-start.exe binary was not and also hard-codes the expected UI version it wants to launch?

Last time this happened, I eventually found and consulted Update System, and manually downloaded the missing file (which at the time was https://updates.safing.io/all/ui/modules/portmaster_v0-7-12.zip) I see that has since been removed, though it's now looking for portmaster_v0-7-13.zip instead (which I assume is pretty old given the existence of 0.8.6).

What did you expect to happen?:

Updates to happen successfully and completely.

How did you reproduce it?:

With automatic installation of updates disabled, I initially accepted the update to 1.6.10 (from 1.6.5 according to the logs) which seemed to be successful (prompted to restart the service, which came straight back seemingly running the new version, all good).

Having come back after a Windows reboot, the UI now doesn't launch correctly (presumably it also wouldn't have at the time, but I didn't try reopening it after the update). Portmaster as a service is running correctly, and the notifier can also be launched and used as normal (but the Open App option leads to the same broken UI).

Debug Information:

Can't currently launch the UI, so no copyable debug info available.

portmaster-start.exe output

NB. There was some fudging with piping the output to a file, as otherwise it appears in the terminal but somehow disappears when the terminal is focused(!). The parent console messages don't appear with a plain call to portmaster-start.exe.

$ ./portmaster-start.exe app --data='C:\ProgramData\Safing\Portmaster'
2024/06/02 21:29:14 fixed os.Stdin after attaching to parent console
2024/06/02 21:29:14 fixed os.Stdout after attaching to parent console
2024/06/02 21:29:14 fixed os.Stderr after attaching to parent console
2024/06/02 21:29:14 attached to parent console
[pmstart] 2024/06/02 20:29:14 WARNING: portmaster-start is marked as a GUI application in order to get rid of the console window.
[pmstart] 2024/06/02 20:29:14 WARNING: CTRL-C will immediately kill without clean shutdown.
[pmstart] 2024/06/02 20:29:14 starting C:\ProgramData\Safing\Portmaster\updates\windows_amd64\app\portmaster-app_v0-2-8\portmaster-app_v0-2-8.exe --data C:\ProgramData\Safing\Portmaster

UI error now shown as above. Requesting process end via Task Manager:

[25196:0602/213008.849:ERROR:network_service_instance_impl.cc(663)] Network service crashed, restarting service.
Error sending from webFrameMain:  Error: Render frame was disposed before WebFrameMain could be accessed
    at WebFrameMain.send (node:electron/js2c/browser_init:2:93682)
    at WebContents.send (node:electron/js2c/browser_init:2:79161)
    at BrowserWindow.<anonymous> (C:\ProgramData\Safing\Portmaster\updates\windows_amd64\app\portmaster-app_v0-2-8\resources\app.asar\api.js:81:33)
    at BrowserWindow.emit (node:events:526:35)
[25196:0602/213008.898:ERROR:gpu_process_host.cc(991)] GPU process exited unexpectedly: exit_code=1
[pmstart] 2024/06/02 20:30:10 app/portmaster-app.zip failed with: error during execution: exit status 1
Error: error during execution: exit status 1

Recent log files

Not sure how log rotation works, but this seems to cover the update (2024-05-31 19:42 UTC+1):

• logs/app/2024-05-26-18-13-37.error.log (ditto all previous log files here)

NJ{"Created":1716747217,"Modified":1716747217,"Expires":1719339217,"Deleted":0}S
executing app/portmaster-app.zip version 0.2.8 on windows amd64
[11232:0526/192420.243:ERROR:command_buffer_proxy_impl.cc(319)] GPU state invalid after WaitForGetOffsetInRange.

• logs/app/2024-06-02-19-56-22.error.log (latest)

NJ{"Created":1717358182,"Modified":1717358182,"Expires":1719950182,"Deleted":0}S
executing app/portmaster-app.zip version 0.2.8 on windows amd64

• logs/core/2024-05-17-06-44-19.log

NJ{"Created":1715928259,"Modified":1715928259,"Expires":1718520259,"Deleted":0}S
executing core/portmaster-core.exe version 1.6.5 on windows amd64
...
240531 19:42:32.576 es/restart:105 > WARN 446 updates: initiating (automatic) restart
240531 19:42:32.688 dules/stop:057 > WARN 448 modules: starting shutdown...
240531 19:42:32.874 < EOF

• logs/core/2024-05-31-18-42-33.error.log (latest)

NJ{"Created":1717180953,"Modified":1717180953,"Expires":1719772953,"Deleted":0}S
executing core/portmaster-core.exe version 1.6.10 on windows amd64

• logs/core/2024-05-31-18-42-33.log (latest)

NJ{"Created":1717180953,"Modified":1717180953,"Expires":1719772953,"Deleted":0}S
executing core/portmaster-core.exe version 1.6.10 on windows amd64
...
240531 20:42:39.963 dater/file:078 > WARN 875 updates: failed to verify C:\ProgramData\Safing\Portmaster\updates\windows_amd64\core\portmaster-core_v1-5-1.exe: failed to read signature file: open C:\ProgramData\Safing\Portmaster\updates\windows_amd64\core\portmaster-core_v1-5-1.exe.sig: The system cannot find the file specified.
...
240602 20:56:22.976 dater/file:078 > WARN 698 updates: failed to verify C:\ProgramData\Safing\Portmaster\updates\all\ui\modules\portmaster_v0-7-13.zip: failed to read signature file: open C:\ProgramData\Safing\Portmaster\updates\all\ui\modules\portmaster_v0-7-13.zip.sig: The system cannot find the file specified.
...
240602 21:25:27.442 dater/file:078 > WARN 776 updates: failed to verify C:\ProgramData\Safing\Portmaster\updates\all\ui\modules\portmaster_v0-7-13.zip: failed to read signature file: open C:\ProgramData\Safing\Portmaster\updates\all\ui\modules\portmaster_v0-7-13.zip.sig: The system cannot find the file specified.
...
240602 21:28:10.516 dater/file:078 > WARN 810 updates: failed to verify C:\ProgramData\Safing\Portmaster\updates\all\ui\modules\portmaster_v0-7-13.zip: failed to read signature file: open C:\ProgramData\Safing\Portmaster\updates\all\ui\modules\portmaster_v0-7-13.zip.sig: The system cannot find the file specified.
...
240602 21:28:53.264 dater/file:078 > WARN 814 updates: failed to verify C:\ProgramData\Safing\Portmaster\updates\all\ui\modules\portmaster_v0-7-13.zip: failed to read signature file: open C:\ProgramData\Safing\Portmaster\updates\all\ui\modules\portmaster_v0-7-13.zip.sig: The system cannot find the file specified.
240602 21:29:15.478 dater/file:078 > WARN 816 updates: failed to verify C:\ProgramData\Safing\Portmaster\updates\all\ui\modules\portmaster_v0-7-13.zip: failed to read signature file: open C:\ProgramData\Safing\Portmaster\updates\all\ui\modules\portmaster_v0-7-13.zip.sig: The system cannot find the file specified.
...