feat: add an option to cancel twaps [SW-102]
What it solves
Ads an option to cancel a twap order. It currently it's hard for other signers that haven't submitted the transaction to cancel a TWAP. By having a cancel button in the Safe Interface every signer would be able to propose a transaction to cancel it.
How to test it
Screenshots
Checklist
- [ ] I've tested the branch on mobile 📱
- [ ] I've documented how it affects the analytics (if at all) 📊
- [ ] I've written a unit/e2e test for it (if applicable) 🧑💻
Branch preview
✅ Deploy successful!
Website: https://feat_cancel_twaps--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6
Storybook: https://feat_cancel_twaps--walletweb.review.5afe.dev/storybook/
ESLint Summary View Full Report
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
| Type | Occurrences | Fixable |
|---|---|---|
| Errors | 0 | 0 |
| Warnings | 0 | 0 |
| Ignored | 0 | N/A |
- Result: :white_check_mark: success
- Annotations: 0 total
Report generated by eslint-plus-action
📦 Next.js Bundle Analysis for safe-wallet-web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
⚠️ Global Bundle Size Increased
| Page | Size (compressed) |
|---|---|
global |
1.19 MB (🟡 +202.36 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Twenty-one Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
507 B (🟢 -24.36 KB) |
1.19 MB |
/address-book |
26.1 KB (🟢 -6 B) |
1.21 MB |
/apps |
48.9 KB (🟢 -1.28 KB) |
1.23 MB |
/apps/custom |
40.52 KB (🟢 -1.28 KB) |
1.23 MB |
/apps/open |
49.38 KB (🟢 -3.91 KB) |
1.24 MB |
/balances |
29.48 KB (🟢 -15 B) |
1.22 MB |
/balances/nfts |
19.16 KB (🟢 -3 B) |
1.21 MB |
/home |
56.52 KB (🟢 -2.17 KB) |
1.24 MB |
/licenses |
4.96 KB (🟢 -3 B) |
1.19 MB |
/new-safe/create |
22.41 KB (🟢 -11.36 KB) |
1.21 MB |
/new-safe/load |
7.68 KB (🟢 -8.71 KB) |
1.19 MB |
/settings/environment-variables |
8.83 KB (🟢 -305 B) |
1.2 MB |
/settings/setup |
35.96 KB (🟢 -6 B) |
1.22 MB |
/share/safe-app |
9.72 KB (🟡 +1 B) |
1.2 MB |
/swap |
605 B (🟡 +1 B) |
1.19 MB |
/transactions |
62.32 KB (🟢 -11.11 KB) |
1.25 MB |
/transactions/history |
62.29 KB (🟢 -11.11 KB) |
1.25 MB |
/transactions/messages |
34.16 KB (🟢 -4.87 KB) |
1.22 MB |
/transactions/msg |
24.56 KB (🟢 -4.87 KB) |
1.21 MB |
/transactions/queue |
27.7 KB (🟢 -3.32 KB) |
1.21 MB |
/transactions/tx |
17.48 KB (🟢 -3.3 KB) |
1.2 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 79.08% (-0% 🔻) |
11733/14836 |
| 🔴 | Branches | 58.85% (+0.03% 🔼) |
2918/4958 |
| 🟡 | Functions | 66.09% (-0.07% 🔻) |
1875/2837 |
| 🟢 | Lines | 80.48% (+0% 🔼) |
10578/13144 |
Show new covered files 🐣
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / composableCowInterface.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / index.tsx |
83.33% | 100% | 0% | 100% |
| 🟡 | ... / CancelCoWOrder.tsx |
66.67% | 100% | 0% | 72.73% |
Show files with reduced coverage 🔻
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / index.tsx |
37.62% (-0.67% 🔻) |
0% | 0% | 39.58% (-0.87% 🔻) |
Test suite run success
1448 tests passing in 199 suites.
Report generated by 🧪jest coverage report action from af92fe84e0a830dcb3560a1f85a8de772721d1c7
An update from @compojoom:
We have the endpoint on CGW now that gives the currently active part for canceling.
So this PR has a chance of eventually being merged. Don't close.
I'll close this PR for now since we don't have capacity to work in this atm, the branch can be restored if needed.