safe-wallet-web icon indicating copy to clipboard operation
safe-wallet-web copied to clipboard

feat: add partially filled state [SWT-51]

Open compojoom opened this issue 2 months ago • 5 comments

Resolves: https://www.notion.so/safe-global/8f5927d10d3643f3a0d2ebc02c8eb425?v=0177347b11784ea69b1883fd88be37ab&p=3b1c5384735c405d8ba91a7fd47772b8&pm=s

Cowswap is showing partially filled limit orders - both expired and open as "partially filled". We now do the same.

Note: i was not able to test with buy limit orders as on sepolia non of the orders I created got filled at all.

How to test it

Create a limit order and it it gets partially filled, you should see it as partially filled. An easy way to create a partially filled order would be to try to sell more tokens than you own. Then cowswap would just sell what you have and will say that it can't fulfil the rest.

Screenshots

Checklist

  • [ ] I've tested the branch on mobile 📱
  • [ ] I've documented how it affects the analytics (if at all) 📊
  • [ ] I've written a unit/e2e test for it (if applicable) 🧑‍💻

compojoom avatar May 07 '24 13:05 compojoom