safe-wallet-web icon indicating copy to clipboard operation
safe-wallet-web copied to clipboard

[Research] Migrate to web3modal

Open katspaugh opened this issue 1 year ago • 1 comments

Research migrating from web3-onboard to web3modal (from WalletConnect). List pros and cons and a possible migration path.

Criteria:

  • Must support Ledger and Trezor
  • Unit tests
  • Customizable CSS

katspaugh avatar Dec 04 '23 11:12 katspaugh

It needs to be able to support custom wallets such as social login.

I would also add RainbowKit and ConnectKit to the list for research

usame-algan avatar Dec 04 '23 11:12 usame-algan

Closing this, the outcome:

  • ➕Web3modal has no issues that onboard has connecting to MetaMask
  • ➕Web3modal has an imrpoved SiWE support, especially with WalletConnect
  • ➕Better EIP-6963 support
  • ➖ No direct Ledger/Trezor support, only via LedgerLive (but they'll have it once the new Ledger SDK is out)

katspaugh avatar May 14 '24 09:05 katspaugh