safe-wallet-web icon indicating copy to clipboard operation
safe-wallet-web copied to clipboard

[EIP1271] Show shareable links in MsgModal and history

Open katspaugh opened this issue 1 year ago • 2 comments

Use this endpoint (routed via CGW) to fetch message details: https://safe-transaction-goerli.safe.global/api/v1/messages/0x7f4032fd13f27c5fce4694a1a6b79f65c68656da4eee4347a414f5bcec915b39/

Create a deep link page for Message details.

Link to it from the Message popup and History. Screenshot 2023-05-22 at 13 40 25

katspaugh avatar May 22 '23 11:05 katspaugh

Would love to see this implemented. As far as I can tell, at this moment in time there is no way to have multiple signers in different physical locations with different devices sign the same EIP1271 signature from a WalletConnect session.

This blocks the ability to login to any service that requires a signature to authenticate.

coffeexcoin avatar Jan 23 '24 02:01 coffeexcoin

cc @kirkkonen

katspaugh avatar Jan 23 '24 09:01 katspaugh

The message only gets created once it get's the first signature, so we can only show the share link after it gets signed. But it would be easy to miss the link appearing since it's up at the top of the page. What about displaying the message nearer the bottom so it's more noticeable? Something like this maybe @TanyaEfremova

Image

jmealy avatar Jun 21 '24 16:06 jmealy

This was indeed intended by design, the message to share the link is shown like this

We can combine both, since the message isn't really clear IMO. I think, the sentence Share the link with other owners can help

TanyaEfremova avatar Jun 24 '24 21:06 TanyaEfremova