safe-wallet-web icon indicating copy to clipboard operation
safe-wallet-web copied to clipboard

[EIP1271] Make Safe compatible using the new off-chain flow when connected to other Safes as owner

Open schmanu opened this issue 1 year ago • 1 comments

Overview

When using Safes or other smart contract wallets as owners, we currently fallback to on-chain approvals using the safe contract's approveHash function.

This has several disadvantages:

  • It costs gas
  • It is slow. The tx needs to be executed and then picked up by our indexer.

This issue wants to implement EIP-1271 signatures for owners which are smart contract wallets.

Requirements

  • [x] https://github.com/safe-global/safe-core-sdk/issues/407
  • [ ] try to use off-chain EIP-1271 signatures. If they do not work, fallback to the on-chain approveHash call

schmanu avatar May 05 '23 10:05 schmanu