safe-wallet-web icon indicating copy to clipboard operation
safe-wallet-web copied to clipboard

Cancel and retry on safe creation timeout is misleading

Open usame-algan opened this issue 1 year ago • 1 comments

Bug description

If the create safe transaction times out, we display a message saying "Please cancel the process or retry the transaction." and give the user the option to cancel the process or retry a new transaction. This will lead to issues as described by Manu here: https://github.com/safe-global/web-core/issues/1355#issuecomment-1366558398

Steps to reproduce

  1. Go to Safe
  2. Create a new safe with a low gas so that the transaction is not being picked up
  3. Wait for 30 minutes
  4. Observe an error saying "Please cancel the process or retry the transaction."
  5. Press Cancel or Retry
  6. On Cancel, observe being able to restart the safe creation flow even though there is still a pending transaction in the wallet
  7. On Retry, observe that a new transaction is being created in the wallet that can't be executed until the pending one is executed

Expected result

TBD

Potential solutions:

  • Display a different message to better educate the user
  • Retry should create a new transaction with the previous nonce
  • Cancel should not be visible

usame-algan avatar Jan 05 '23 13:01 usame-algan