safe-wallet-web icon indicating copy to clipboard operation
safe-wallet-web copied to clipboard

Cancel and retry on safe creation timeout is misleading

Open usame-algan opened this issue 2 years ago • 1 comments

Bug description

If the create safe transaction times out, we display a message saying "Please cancel the process or retry the transaction." and give the user the option to cancel the process or retry a new transaction. This will lead to issues as described by Manu here: https://github.com/safe-global/web-core/issues/1355#issuecomment-1366558398

Steps to reproduce

  1. Go to Safe
  2. Create a new safe with a low gas so that the transaction is not being picked up
  3. Wait for 30 minutes
  4. Observe an error saying "Please cancel the process or retry the transaction."
  5. Press Cancel or Retry
  6. On Cancel, observe being able to restart the safe creation flow even though there is still a pending transaction in the wallet
  7. On Retry, observe that a new transaction is being created in the wallet that can't be executed until the pending one is executed

Expected result

TBD

Potential solutions:

  • Display a different message to better educate the user
  • Retry should create a new transaction with the previous nonce
  • Cancel should not be visible

usame-algan avatar Jan 05 '23 13:01 usame-algan

With https://github.com/safe-global/safe-wallet-web/pull/3242 we are adding a new Event Bus for safe creations which we can also reuse here.

As an addition I would suggest we only move the user to the status screen once they submit in their wallet. As long as they reject the transaction they should still be on the review screen to simplify the flow.

usame-algan avatar Feb 14 '24 12:02 usame-algan

Closing this issue since #3612 was merged which overhauled the status screen.

The Cancel button is now only visible if there was an actual error during transaction execution. This ensure that the transaction is not pending when the user can Cancel the creation.

The Retry button is also only visible if there was an actual error and will take the user back to the safe creation review screen.

usame-algan avatar Jul 03 '24 11:07 usame-algan