safe-smart-account icon indicating copy to clipboard operation
safe-smart-account copied to clipboard
verified publisher icon safe-global

Adjust 1.4.1 tests for zkSync

Open ElvisKrop opened this issue 2 years ago • 4 comments

As agreed previously https://github.com/safe-global/safe-contracts/pull/588#issuecomment-1613617245

ElvisKrop avatar Jul 25 '23 12:07 ElvisKrop

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Jul 25 '23 12:07 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

ElvisKrop avatar Jul 25 '23 13:07 ElvisKrop

I have read the CLA Document and I hereby sign the CLA

nick8319 avatar Jul 27 '23 13:07 nick8319

Hello @mmv08! I hope you are doing well :relieved: I was able to rebase this branch onto the main with latest changes. However, we cannot merge zksync related changes as zksync packages use ethers-v5, while main branch has some deps that rely on ethers-v6. Please take a look at this issue (https://github.com/matter-labs/hardhat-zksync/issues/311) created by @NomicFoundation in June. It's sad...

I can see only two options here:

  1. If zksync changes must get in the main branch before the next release - we have to downgrade all dependencies back in the repository to use ethers-v5. After @matter-labs migrates all their packages to the ethers-v6 we can migrate too.
  2. Otherwise, we have to wait until @matter-labs will migrate to the ethers-v6. Only then we can come back to this PR and try to make it work.

Both options are not so good from dev perspective. If you have anything in mind, please let us know.

ElvisKrop avatar Aug 31 '23 14:08 ElvisKrop