safe-smart-account icon indicating copy to clipboard operation
safe-smart-account copied to clipboard

Allow to set a transaction guard for each enabled module

Open auryn-macmillan opened this issue 2 years ago • 2 comments

Context / issue

Transaction guards are a really powerful feature for the Gnosis Safe, but they are currently limited only to multisig transactions. Any installed modules circumvent an enabled transaction guard. If a user would like to implement similar logic for a module, they would need to implement it either as part of their module or as a modifier module that sits between their module and the safe.

Proposed solution

Allow users to optionally enable a guard for each enabled module. This would allow each enabled module to have distinct pre and/or post-checks that it must pass each time it time it attempts to execute a proposal.

Alternatives

The alternative is to build this logic directly into modules or as a modifier module that sits between enabled modules and the safe. In either case, this would mean duplicating code to enable similar guard functionality for module and multisig transactions.

Additional context

If this is implemented, we can create a IGuardable.sol interface in Zodiac and encourage the DAO community to build more compatible transaction guards.

auryn-macmillan avatar Aug 20 '21 19:08 auryn-macmillan

Deployment approve

Emmanuelruina avatar Nov 15 '23 18:11 Emmanuelruina

Deployment approve

Thanks

mmv08 avatar Nov 15 '23 19:11 mmv08