safe-react icon indicating copy to clipboard operation
safe-react copied to clipboard

[Epic] Roles: transaction drafters

Open DiogoSoaress opened this issue 2 years ago • 5 comments

Overview

The Safe UI is missing a way to manage transaction drafters (aka delegates)

Requirements

  • [ ] Implement a Settings page for transaction drafters management
  • [ ] Update the Client GW SDK to expose the CRUD /delegates endpoints

Timeline

  • Picking up the current PoC it should take around 3 working days to connect with the SDK endpoints (instead of calling Transaction Service directly). Design rework will add to this estimation which should not blow 1 week of work

  • Client GW SDK has an open PR that should take 1 working day to finalize.

Designs

Requires @liliiaorlenko Screenshot 2022-06-07 at 11 04 15 Screenshot 2022-06-07 at 11 05 41 Screenshot 2022-06-07 at 11 06 20

Links

Notion doc Original Problem Statement

Transaction Service API Gnosis-Safe Delegation DAPP (external)

DiogoSoaress avatar Jun 09 '22 14:06 DiogoSoaress

Does the timeline take into account the adjustments required on backend and allowance of transaction proposal by delegates?

iamacook avatar Jun 09 '22 14:06 iamacook

Does the timeline take into account the adjustments required on backend and allowance of transaction proposal by delegates?

Only frontend work as we agreed in the meeting earlier. IIRC

DiogoSoaress avatar Jun 09 '22 15:06 DiogoSoaress

Only frontend work as we agreed in the meeting earlier. IIRC

We need to adjust the proposal logic though if we want to allow delegates to draft transactions or is this epic purely for the CRUD system?

iamacook avatar Jun 09 '22 15:06 iamacook

The way I wrote it was for delegate role management purely. However you have a valid question. cc @johannesmoormann

DiogoSoaress avatar Jun 09 '22 15:06 DiogoSoaress

I reached out to backend as the DELETE HTTP method, used to delete transaction delegates, is not allowed by CORS policy in the Client GW.

@johannesmoormann this is a dependency we have on the backend team (as @iamacook had identified before)

DiogoSoaress avatar Jun 09 '22 18:06 DiogoSoaress