safe-react
safe-react copied to clipboard
Better display of "Transaction Builder" transactions.
Currently, transactions created by the popular "Transaction Builder" are very hard to understand:
- addresses are shown only as hex, and don't get expanded to their addressbook values
- "data" is show in hex, instead of getting expanded as method calls.
- This means that transactions created by the "builder" are harder to verify by co-signers (before execution) and harder to understand from history (after execution
suggestion:
Each "action" in the transaction builder should be decoded just lkie every "top-level" transaction on the safe.
Thanks @drortirosh, good points!
@dasanra is this backend or frontend?
With the new UI, Such transaction can be created using the "CSV Airdrop" application. After submitting such batched transaction, the transaction should be approved by other safe owners. Below is sample view. As you can see, the "Token" part is very hard to review
- the token is displayed with address only, instead of showing its symbol/description.
- the receipient address of ETH is expanded from the addressbook. but the recipient of a token transfer is left as hex string
- the value is left as
uint256
, instead of using the token'sdecimals
values. These are all small UI changes, but would greatly improve the usability of the transaction builder tool (note that the "value" translation is related (to token value, but AFAIK, this is the #1 use-case of batched transactions..)
In general, the display processing of each transaction in a batch should be exactly as for a single transaction called directly by "executeTransaction"