safe-react icon indicating copy to clipboard operation
safe-react copied to clipboard

Ledger: gas estimation from Safe is overwritten by Ledger

Open katspaugh opened this issue 3 years ago • 3 comments

From Discord:

user on EH Mainnet is having issues with editing the gas price on the advanced options. When user tried to execute the transaction, Gnosis estimated 59 gas price, so he increased it to 65 and when the transaction went through it dropped to 51. Why does the gas price changed to a lower value even though it was set at a higher gas price?

User was using Ledger Nano S, updated to the most recent firmware (2.1.0)

He said he never had this issue before, only recently.

katspaugh avatar Dec 23 '21 15:12 katspaugh

I suspect this isn't Ledger specific. I'm using a Trezor One, overrode the gas price of over 200gwei under advanced to be about 80gwei. I did not notice that it had ignored my override and submitted a transaction with the larger default fee. Confirmed this happened again, and it showed the wrong (unoverriden) on the Trezor screen.

eglaysher avatar Jan 02 '22 01:01 eglaysher

@francovenica could you verify this behavior?

johannesmoormann avatar Jan 17 '22 16:01 johannesmoormann

TL;DR: Our estimation is not being passed to the ledger, some oracle is estimating for us when the tx reaches the device

In ETH mainnet, I tried to artificially set it 70k gas limit and 200 Gwei for an estimated 0.014 eth fee, but the leger showed a number more close to the initial estimation of 69300k gas limit and 90 Gwei for an estimated 0.0062 eth fee image

I tried the same in rinkeby. There we estimate with the values that the oracle returns for ethereum mainnet, but in reality 1Gwei is enough price for any transaction, so what you can see in the ledger is an estimated fee taking the Gwei price of 1, instead of the price set during the tx review.

francovenica avatar Jan 19 '22 01:01 francovenica

Will be fixed in safe-global/web-core#700.

katspaugh avatar Sep 28 '22 07:09 katspaugh