safe-react icon indicating copy to clipboard operation
safe-react copied to clipboard

Safe Creation/Load forms - default to randomly generated Owner names

Open francovenica opened this issue 3 years ago • 4 comments

Description

The names of the owners during the safe creation/load should be filled before continuing with the form. Currently you can leave those names empty

Environment

  • Browser: Any
  • Wallet: Any
  • Safe: Any
  • Environment:
    • Prod: https://rinkeby.gnosis-safe.io/ (no L2UX yet)
    • Dev: https://safe-team.dev.gnosisdev.com/app/open (with L2UX)

Steps to reproduce

  1. Enter into the safe/load forms (same issue for both). This is a safe in rinkeby 0x9913B9180C20C6b0F21B6480c84422F6ebc4B808
  2. Reach the owner adding/name steps
  3. Leave some owners without naming them

Expected result

Errors are shown in the fields with no names. You should not be able to get to the review step

Obtained result

No errors are shown. You can leave the name fields empty

Requirements

  • Auto-generate default names (placeholders)
  • If the owner is already in AB, default to that
  • The same as is done for the Safe names

Use the format like fantastic-rinkeby-owner

Bonus

If possible, include the address's wallet in the name, e.g.:

fantastic-rinkeby-metamask
funky-polygon-ledger

francovenica avatar Oct 22 '21 13:10 francovenica

@francovenica, I have a feeling that during Addressbook v2 implementation we have agreed that the owner name can be empty. May be you know where such information can be listed - addressbook PR?

liliya-soroka avatar Oct 26 '21 08:10 liliya-soroka

@liliya-soroka is right, we allowed them to be empty, I remember now. I suggest, however, that we fall back to a randomly generated name, the same as default Safe names.

katspaugh avatar Oct 26 '21 08:10 katspaugh

@liliya-soroka I asked the other day and really didn't remember if this was a change we did on purpose or not. I like the idea of randomly generated names though.

francovenica avatar Oct 26 '21 11:10 francovenica

I think it's very useful to always have names for the owners. The label box can be prefilled by a generated name, like Owner 4 and user can decide to use a custom name. Even if the user don't know the name of the other owners is very useful to see in the transactions tab that you are sending/receiving assets from owners

Uxio0 avatar Oct 29 '21 10:10 Uxio0

Closing because Safe creation has been reworked in web-core.

katspaugh avatar Sep 28 '22 08:09 katspaugh