safe-react icon indicating copy to clipboard operation
safe-react copied to clipboard

Add advanced parameters to spending limit transaction

Open dasanra opened this issue 3 years ago • 1 comments

What is this feature about? (1 sentence)

Currently for spending limit transactions we are not showing the advanced parameters form. This was caused because there were some issues on how gas was handled for safe transactions and we added a refactor that at least stopped showing an error warning when creating a spending limit transaction. As we stated that to make this works it involved more changes we decided to create an epic to properly iterate over the advance parameters form

Why is it needed? What is the value? For whom do we build it?

To be consistent with transactions created by the safe, we need to allow the user to set advanced parameters also in spending limit transaction. Gas for a spending limit transaction is different as for a safe transaction, as there is no safeTxGas involved and gas limit estimation and execution check shouldn't be done agains the safe address

High-level overview of the feature

  • Enable advanced parameter for spending limit transactions
  • Refactor or add the necessary methods to estimate gas limit and do the execution check (eth_call)

dasanra avatar Apr 09 '21 07:04 dasanra

Snapshots on how tx created by spending limit look like today: Form: image

Review Step: image

Tx executed: image

francovenica avatar Dec 09 '21 13:12 francovenica