safe-ios
safe-ios copied to clipboard
[iOS] Default token list toggle in asset overview
As a mobile user
I don’t want to see any spam tokens
so that I’m better secured and can get a clearer overview of my assets
Background
This story refers to the epic https://github.com/safe-global/web-core/issues/865 created by the web team and includes implementation of a toggle switching between the curated state of tokens and the non-curated state.
In the following I have copy/pasted some parts of the https://github.com/safe-global/web-core/issues/865 for you to not have to switch between the different requirements/links
Details
- By default only a list of curated tokens will be displayed
- The relevant infrastructure piece for holding the default token list in sync is implemented here https://github.com/safe-global/safe-transaction-service/issues/1281
- The UI offers a way to toggle between showing all tokens / only default tokens
- The selected list will have an effect on the total balance but will not affect the transaction history
- The implementation will not include hiding of specific tokens
Concrete to-do’s
- [ ] Designs
- [ ] Implemented UI according to designs
- [ ] When accessing the “Assets” tab the “Default list” loads/is displayed (the list filtering out the spam tokens)
- [ ] When switching the toggle to all the balances are reloaded and all tokens are shown
- [ ] Implementation of analytics events for the two toggle states
Designs
Web designs can be found here https://www.figma.com/file/ZKWJPH1MjJIyUDTHYD3kk8/Default%2FHidden-token-lists?node-id=2%3A26&t=dfhl78RKdaztgU6u-0
Explored a few ways of showing it in the UI:
- Hiding tokens with a screen of token selection with toggle. Additionally you can toggle on and off all tokens (this is based on the UI in web currently)
- Second iteration is for filtering tokens by showing all, or showing a default "curated list". When default list is selected, a user can still adjust which tokens they want to see in the UI.
- Hiding settings from the Opt. 2 under one floating button
I hope this is the right place for my questions:
- ~~Is there a way to get the default list back? Assuming I disabled or enabled all tokens and want to get back to the default (curated) list~~ <- Apparently this is a feature for the second iteration.
- I assume in the following screen the "Back" button saves the selection as well as the "save" button?
Regarding the "Filter lists" from V2. Will there be always only "all tokesn" and "default" list? Or will it be possible for the user to save their lists?
On your questions Dirk: "I assume in the following screen the "Back" button saves the selection as well as the "save" button?" I would say they are only saved in case the user presses "Save". @TanyaEfremova what do you think?
"Regarding the "Filter lists" from V2. Will there be always only "all tokesn" and "default" list? Or will it be possible for the user to save their lists?" Generally I think custom lists might be a good idea, but for now I wouldn't tackle it and since I would like to have the UI more clean in general I'm not sure if we should offer it at all. But I think the users will tell us. @TanyaEfremova any thoughts here?