safe-eth-py icon indicating copy to clipboard operation
safe-eth-py copied to clipboard

Remove delegate API client shouldn't sign the message

Open moisses89 opened this issue 1 year ago • 1 comments

What is needed?

The function remove_delegate of transaction service api is signing the message with wallet provided by parameter, but this signature should happens outside of the remove_delegate function to let other types of wallets as hardware wallets sign the message. I'd suggest that remove_delegate should just receive the message_hash and the signature.

moisses89 avatar Jan 24 '24 15:01 moisses89

Makes total sense @moisses89 , good call

Uxio0 avatar Jan 24 '24 16:01 Uxio0