safe-eth-py icon indicating copy to clipboard operation
safe-eth-py copied to clipboard

`estimate_tx_gas_by_trying` is looping over exceptions always on arbitrum

Open moisses89 opened this issue 1 year ago • 0 comments

Describe the bug estimate_tx_gas_by_trying is trying 30 times to execute the following line, https://github.com/safe-global/safe-eth-py/blob/master/gnosis/safe/safe.py#L768 but in arbitrum it is throwing an exception in every iteration because the gas_limit calculated in each iteration is always not enough.

Expected behavior The expected behaviour should be can estimate the gas withour exception, or less exceptions.

Additional context Maybe the hardcoded gas_limit increment of 32000 is not enough, I propose to change this hardcoded value to a variable that can be configured by chain or keep a default value depending the case.

moisses89 avatar Aug 28 '23 10:08 moisses89