safe-core-sdk icon indicating copy to clipboard operation
safe-core-sdk copied to clipboard

Revert with `GS025` despite transaction being approved

Open thomas-waite opened this issue 2 years ago • 1 comments

Description

I am forking mainnet and getting a revert GS025 for a 5 of 9 Gnosis Safe when using the Core SDK.

I have created the safe with the sdk and instantiated 5 versions of the SDK with the different safe Owners. I then retrieve the transaction hash and call approveTransactionHash(). It looks like the below:

const safeTx = await sdk1.createTransaction(txArgs);
const txHash = await sdk1.getTransactionHash(safeTx);
const approveTx = await sdk1.approveTransactionHash(safeTx);

..... and so on

I then check that the approvals is as expected (getOwnersWhoApprovedTx(safeTx)) and there are 5. However when I then executeTransaction() it reverts with GS025 - indicating the hash was incorrect. The nonce of the safe and the signed transaction is 0.

I'm not sure why as all the approvals are as expected. Would appreciate any help!

Environment

  • Safe Core SDK version: 2.1.0
  • Environment:
    • non-browser

Can't find a Discord invite - will happily join and ask in supprot

thomas-waite avatar May 06 '22 23:05 thomas-waite