safe-core-sdk icon indicating copy to clipboard operation
safe-core-sdk copied to clipboard

The `SAFE_TX_TYPEHASH` value is wrong for `< 1.0.0` Safe versions

Open pcaversaccio opened this issue 1 year ago • 1 comments

Safe multisig versions < 1.0.0 use a legacy (i.e. the parameter value baseGas was called dataGas previously) SAFE_TX_TYPEHASH value. Starting with version 1.0.0, baseGas was introduced: https://github.com/safe-global/safe-smart-account/pull/90.

https://github.com/safe-global/safe-core-sdk/blob/014f365e46cf278897c5ece45c1490c7c749f2d7/packages/protocol-kit/src/utils/eip-712/index.ts#L39-L52

pcaversaccio avatar Dec 06 '24 11:12 pcaversaccio

Fwiw, I shipped support now for Safe versions 0.1.0 in my Bash script: https://github.com/pcaversaccio/safe-tx-hashes-util/pull/9

pcaversaccio avatar Dec 06 '24 12:12 pcaversaccio