mpesa-php-sdk icon indicating copy to clipboard operation
mpesa-php-sdk copied to clipboard

env variables returning null if config is cached

Open jeygith opened this issue 6 years ago • 4 comments

Hi! good work on this however, there's a slight issue with how you get the env variables in the Mpesa class. Once the config is cached, via config:cache, the .env file is no longer loaded and calls to the env function return null. I'd suggest you create a config file for the sdk where the consumer keys and secret or any other variable can be set.

jeygith avatar Feb 28 '18 05:02 jeygith

Hello @jeygith , thanks for the feedback. I have taken the issue into consideration and we will include that fix in our next release.

mossey avatar Mar 21 '18 15:03 mossey

These can be fixed on the move, you dont need to wait for a whole release to correct such. Are pull requests ok?

nikklass avatar Mar 27 '18 15:03 nikklass

Yeah @nikklass PRs are okay

mossey avatar Sep 15 '18 13:09 mossey

@nikklass hi, did you create this pull request?

jaymoh avatar Jul 30 '21 19:07 jaymoh