Sævar Öfjörð Magnússon

Results 57 comments of Sævar Öfjörð Magnússon

Did you have a chance to take a look at this @vossisboss ?

@UDAR-TomH thanks for your input. I've added a very basic ARIA label. The default template provided is intentionally left quite simple, since most of the time you would want to...

I'd say the bullets are at least not the best layout. So would go for either layout 1 or 2.

@SanchoPanza8000 thanks for the feedback. Unfortunately I have little experience with Wagtail and headless so I would not be the best person to build these examples. This PR was meant...

> * Whitespace and formatting is a bit ad-hoc, running force Prettier on it should resolve this. @lb- can you elaborate? I don't see a Prettier command in the project...

This was introduced in #9816, more specifically the line that sets the font size to 1rem: https://github.com/wagtail/wagtail/blob/1ffa497886d6d5de72eac200c9f8dad6cec9af28/client/scss/components/_userbar.scss#L85 Maybe this was intended behaviour, maybe not. But I believe a Wagtail component...

I see your point, but this does make life harder for developers that actually re-define the base font size to set up font sizes in their websites. I do believe...

Just to be clear, since I don't know where this was discussed or decided, the goal is to change the size of the userbar when the user has a preference...