Ben Kimock

Results 249 comments of Ben Kimock

> It seems rather fragile to rely on optimizations to have this symbol removed from the crate. I do agree that relying on an optimization is generally not good. But......

Just double-checking that the approach `nix` prefers actually works @bors try

I don't know if this is already well-known, but I was reading Adam's great blog post about this situation: https://blog.adamchalmers.com/crazy-compile-time/ and I'm pretty sure that the compile time here would...

As someone who delivers software written in Rust to RHEL environments, I would really like to hear from users who are developing on RHEL using the distro `rustc`/`cargo` instead of...

I mean for our usage, the rest of RHEL packages are an obstacle, so we never even considered using a Rust toolchain from the distro. So I wonder if this...

🤨 Is the problem here just that custom MIR doesn't have coherent spans? Is it supposed to? My instinct is that anyone using custom MIR has already opted out of...

Ah I see! My brain grouped the diagnostic with the wrong span in the error. At first glance this seems pretty thorny to do a good diagnostic for. Hm.

Based on their comments, `crossbeam-epoch` is just incompatible with Stacked Borrows, it's `crossbeam-deque` that actually has UB.

> I only observed UB on release builds with panic = "abort" makes it distinctly unlikely that this is related to using an unavailable CPU feature.

That diagnostic is just identifying the `&Header` pattern, which Stacked Borrows does not allow and the fact that Stacked Borrows forbids the pattern is a known defect in Stacked Borrows....