Saem Ghani
Saem Ghani
Keeping this focused on the Lexer and NimConf, will change others in follow-up PRs.
Thanks for the review, @zerbina.
This is far more complicated than it seems, we effecitively cannot tell when to free these reports. We need to know if we've logically passed them by or not and...
The error storage needs to be tied to the lifetimes of the AST to which they relate -- it gets complicated if we emit an `nkError` that should then 'poison'...
Ah, this is the escaping happening for markdown input, likely needs some tuning.
Thanks for the PR @morganholly, I'm not sure I necessarily understand the change. Could you explain it so I can compare it with my own understanding?
I'm a little confused by the issue, I get that hover etc are not working, the part about scoop, paths, etc that was too just get things to compile, but...
I'm guessing it's a choosenim issue, the extension really doesn't do much special here.
Great investigation. I'm wondering do you think you could detect the issue and maybe output an error telling the user that their nimsuggest/choosenim might be busted?
nim is hardcoded, why don't make it an option so that "nimble" or custom script can be used instead?
That's an easy enough PR to wire in with the config, but if it's just me then I'm not inclined to write only to then maintain yet another path.